1. 添加cache life time的支持。默认10s

2. 优化server:port的解析，使其可以单独定义ip端口或者一起定义
3. 使用fmt格式化整个工程

src/client.rs

@@ -1,12 +1,12 @@
+use clap::{App, Arg};
 use lws_client::LwsVfsIns;
 use std::thread;
-use clap::{Arg, App};
 extern crate log;
 
 use std::env;
 
 const DEFAULT_PORT: u16 = 33444;
-
+const DEFAULT_CACHE_LIFE: u32 = 10_000;
 // use std::process::{Command,Stdio};
 // fn get_ssh_clinet() -> String {
 //     // Run `who` command
@@ -51,50 +51,83 @@ fn get_ssh_clinet() -> String {
     client.to_string()
 }
 
-fn param_parser() -> (String, String) {
+fn param_parser() -> (String, String, u32) {
     let matches = App::new("lws_client")
         .version("1.0")
         .author("Ekko.bao")
         .about("linux&windows shared filesystem")
-                    .arg(Arg::with_name("s")
+        .arg(
+            Arg::with_name("s")
                 .short('s')
                 .long("server")
                 .takes_value(true)
+                .min_values(1)
+                .max_values(1)
                 .value_name("server")
-                        .help(format!("server addr: [ip[:port]], default is [sshclient:{}]", DEFAULT_PORT).as_str()))
+                .help(
-                    .arg(Arg::with_name("m")
+                    format!(
+                        "server addr: [ip[:port]], default is [sshclient:{}]",
+                        DEFAULT_PORT
+                    )
+                    .as_str(),
+                ),
+        )
+        .arg(
+            Arg::with_name("m")
                 .short('m')
                 .long("mount")
                 .takes_value(true)
+                .min_values(1)
+                .max_values(1)
                 .value_name("mount point")
                 .required(true)
-                        .help("mount point, eg: ~/mnt"))
+                .help("mount point, eg: ~/mnt"),
+        )
+        .arg(
+            Arg::with_name("c")
+                .short('c')
+                .long("cache")
+                .takes_value(true)
+                .min_values(1)
+                .max_values(1)
+                .value_name("cache invalid time")
+                .help("file info cache invalid time, unit: ms, defualt is 10_000ms"),
+        )
         .get_matches();
-    let server = match matches.value_of("s") {
+    let (ip, port) = match matches.value_of("s") {
         Some(server) => {
             let split = server.split(":").collect::<Vec<&str>>();
             if split.len() == 2 {
-                server.to_string()
+                (split[0].to_string(), split[1].to_string())
             } else {
-                format!("{}:{}", split[0], DEFAULT_PORT)
+                (split[0].to_string(), DEFAULT_PORT.to_string())
             }
-        },
-        None => {
-            let ip = get_ssh_clinet();
-            format!("{}:{}", ip, DEFAULT_PORT)
         }
+        None => (String::new(), String::new()),
     };
+    let ip = if ip.len() == 0 { get_ssh_clinet() } else { ip };
+    let port = if port.len() == 0 {
+        DEFAULT_PORT.to_string()
+    } else {
+        port
+    };
+    let server = format!("{}:{}", ip, port);
     log::info!("args server: [{}]", server);
     let mount_point = matches.value_of("m").unwrap().to_string();
     log::info!("args mount_point: [{}]", mount_point);
-    (server, mount_point)
+    let cache_life = match matches.value_of("c") {
+        Some(cache_life) => cache_life.parse().unwrap(),
+        None => DEFAULT_CACHE_LIFE,
+    };
+    log::info!("args cache invalid time: [{}ms]", cache_life);
+    (server, mount_point, cache_life)
 }
 
 #[tokio::main]
 async fn main() -> Result<(), Box<dyn std::error::Error>> {
     env_logger::init();
-    let (server, mount_point) = param_parser();
+    let (server, mount_point, cache_life) = param_parser();
-    let lws_ins = match LwsVfsIns::new(&server).await {
+    let lws_ins = match LwsVfsIns::new(&server, cache_life).await {
         Ok(ins) => ins,
         Err(e) => {
             log::error!("Error creating lws server instance: {:?}", e);
@@ -110,24 +143,21 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
         _ => {}
     }
     log::info!("start mount process");
-    let handle =  thread::spawn(move ||{
+    let handle = thread::spawn(move || match LwsVfsIns::mount(&mount_point, lws_ins) {
-        match LwsVfsIns::mount(&mount_point, lws_ins) {
+        Ok(_) => Ok::<i32, String>(0),
-            Ok(_) => {
-                Ok::<i32, String>(0)
-            },
         Err(e) => {
             log::error!("mount err {:?}", e);
             Ok::<i32, String>(-1)
         }
-        }
     });
     match handle.join() {
-        Ok(_) => {
+        Ok(_) => Ok(()),
-            Ok(())
-        },
         Err(e) => {
             log::error!("mount thread start err {:?}", e);
-            Err(Box::new(std::io::Error::new(std::io::ErrorKind::Other, "mount fail")))
+            Err(Box::new(std::io::Error::new(
+                std::io::ErrorKind::Other,
+                "mount fail",
+            )))
         }
     }
 }

src/lib.rs

@@ -1,18 +1,18 @@
+use hashbrown::HashMap;
 use lws_client::lws_vfs_client::LwsVfsClient;
 use lws_client::{
-    Access, Create, FileInfo, Flush, Fstat, Getattr, HelloRequest, Mkdir, Open, Opendir, Read,
+    Access, Create, FileInfo, Flush, Fstat, GetConfig, Getattr, HelloRequest, Mkdir, Open, Opendir,
-    Readdir, Release, Releasedir, Rename, Rmdir, Timespec, Truncate, Unlink, Utimens, Write, GetConfig,
+    Read, Readdir, Release, Releasedir, Rename, Rmdir, Timespec, Truncate, Unlink, Utimens, Write,
 };
 use serde_json::{self, Value};
-use hashbrown::HashMap;
 use std::error::Error;
-use std::ffi::{OsStr};
+use std::ffi::OsStr;
 use std::fs::File;
-use std::{env, path, vec};
 use std::io::{Error as IoError, ErrorKind, Read as IoRead};
-use tonic::transport::{Channel as RpcChannel};
-use tokio::runtime::{Builder,Runtime};
 use std::thread::{self, JoinHandle};
+use std::{env, path, vec};
+use tokio::runtime::{Builder, Runtime};
+use tonic::transport::Channel as RpcChannel;
 extern crate log;
 
 pub mod lws_client {
@@ -44,9 +44,7 @@ impl Config {
                 )
             })
             .collect();
-        Ok(Config {
+        Ok(Config { mount_map })
-            mount_map,
-        })
     }
 
     pub fn get_mount(&self) -> Vec<&String> {
@@ -84,7 +82,12 @@ impl RpcPool {
             clients.push(Arc::new(RwLock::new(Rpc {
                 client,
                 in_use: false,
-                rt: Arc::new(Builder::new_multi_thread().worker_threads(1).build().unwrap()),
+                rt: Arc::new(
+                    Builder::new_multi_thread()
+                        .worker_threads(1)
+                        .build()
+                        .unwrap(),
+                ),
                 tx: Arc::new(tx),
                 rx: Arc::new(Mutex::new(rx)),
             })));
@@ -109,7 +112,8 @@ impl RpcPool {
                 let entry = clients[idx].read().unwrap();
                 if !entry.in_use {
                     drop(entry);
-                    let mut entry: std::sync::RwLockWriteGuard<'_, Rpc> = clients[idx].write().unwrap();
+                    let mut entry: std::sync::RwLockWriteGuard<'_, Rpc> =
+                        clients[idx].write().unwrap();
                     entry.in_use = true;
                     return Ok(clients[idx].clone());
                 }
@@ -272,15 +276,16 @@ pub struct FileAttrCache{
 use std::time::UNIX_EPOCH;
 fn current_time_in_ms() -> u32 {
     let start = SystemTime::now();
-    start.duration_since(UNIX_EPOCH)
+    start
+        .duration_since(UNIX_EPOCH)
         .expect("Time went backwards")
         .as_millis() as u32
 }
 impl FileAttrCache {
-    pub fn new(attr: FileAttrInfo) -> FileAttrCache{
+    pub fn new(attr: FileAttrInfo, cache_life: u32) -> FileAttrCache {
         FileAttrCache {
             attr,
-            exp_time: current_time_in_ms() + 10_000,
+            exp_time: current_time_in_ms() + cache_life,
         }
     }
 }
@@ -313,25 +318,22 @@ pub struct FileAttrCacheManager{
 }
 
 impl FileAttrCacheManager {
-    pub fn new() -> FileAttrCacheManager{
+    pub fn new(cache_life: u32) -> FileAttrCacheManager {
         let (tx, rx) = mpsc::channel();
         let cache_ctx = FileAttrCacheCtx::new(rx);
-        let handle = thread::spawn(|| {
+        let handle = thread::spawn(move || {
-            Self::cache_manager(cache_ctx);
+            Self::cache_manager(cache_ctx, cache_life);
         });
-        FileAttrCacheManager{
+        FileAttrCacheManager { handle, tx }
-            handle,
-            tx,
-        }
     }
 
-    fn cache_manager(mut ctx: FileAttrCacheCtx) {
+    fn cache_manager(mut ctx: FileAttrCacheCtx, cache_life: u32) {
         let rx = ctx.rx.lock().unwrap();
-        
         fn invalid_cache(cache: &mut HashMap<String, FileAttrCache>) -> u32 {
             let mut cache_size = 0;
             let curr = current_time_in_ms();
-            let del:Vec<String> = cache.iter()
+            let del: Vec<String> = cache
+                .iter()
                 .filter(|&(_, val)| val.exp_time < curr)
                 .map(|(key, _)| key.clone())
                 .collect();
@@ -350,31 +352,29 @@ impl FileAttrCacheManager {
                     }
                     match req {
                         FileAttrCacheMsg::Set(path, attr) => {
-                            ctx.cache.insert(path, FileAttrCache::new(attr));
+                            ctx.cache.insert(path, FileAttrCache::new(attr, cache_life));
                             ctx.cache_size += 1;
-                        },
+                        }
-                        FileAttrCacheMsg::Get(path, chn) => {
+                        FileAttrCacheMsg::Get(path, chn) => match ctx.cache.get(&path) {
-                            match ctx.cache.get(&path) {
                             Some(attr) => {
                                 let _ = chn.send(FileAttrCacheMsg::GetReply(path, Some(attr.attr)));
-                                },
+                            }
                             None => {
                                 let _ = chn.send(FileAttrCacheMsg::GetReply(path, None));
                             }
-                            } 
                         },
                         FileAttrCacheMsg::Clr(paths) => {
                             for path in paths.into_iter() {
                                 ctx.cache.remove(&path);
                                 ctx.cache_size -= 1;
                             }
-                        },
+                        }
                         _ => {}
                     }
-                },
+                }
                 Err(_) => {
                     ctx.cache_size -= invalid_cache(&mut ctx.cache);
-                },
+                }
             }
         }
     }
@@ -383,15 +383,22 @@ impl FileAttrCacheManager {
         let _ = self.tx.send(FileAttrCacheMsg::Set(path.to_string(), attr));
     }
 
-    pub fn get(&self, path:&String, tx: &Arc<mpsc::Sender<FileAttrCacheMsg>>, rx: &Arc<Mutex<mpsc::Receiver<FileAttrCacheMsg>>>) -> Option<FileAttrInfo> {
+    pub fn get(
+        &self,
+        path: &String,
+        tx: &Arc<mpsc::Sender<FileAttrCacheMsg>>,
+        rx: &Arc<Mutex<mpsc::Receiver<FileAttrCacheMsg>>>,
+    ) -> Option<FileAttrInfo> {
         //send get gile attribute request
-        let _ = self.tx.send(FileAttrCacheMsg::Get(path.to_string(), tx.clone()));
+        let _ = self
+            .tx
+            .send(FileAttrCacheMsg::Get(path.to_string(), tx.clone()));
         let total_timeout = Duration::from_millis(100);
         let start = Instant::now();
         loop {
             let elapsed = start.elapsed();
             if elapsed >= total_timeout {
-                return None
+                return None;
             }
             let timeout = total_timeout - elapsed;
             let resp = {
@@ -406,7 +413,7 @@ impl FileAttrCacheManager {
                         //message is not match
                         return resp;
                     }
-                },
+                }
                 _ => break,
             }
         }
@@ -459,8 +466,7 @@ impl FilesystemMT for LwsVfsIns {
     }
 
     /// Called on filesystem unmount.
-    fn destroy(&self) {
+    fn destroy(&self) {}
-    }
 
     /// Get the attributes of a filesystem entry.
     ///
@@ -1507,10 +1513,8 @@ impl FilesystemMT for LwsVfsIns {
     }
 }
 
-
-
 impl LwsVfsIns {
-    pub async fn new(server: &String) -> Result<LwsVfsIns, Box<dyn Error>> {
+    pub async fn new(server: &String, cache_life: u32) -> Result<LwsVfsIns, Box<dyn Error>> {
         let addr = format!("http://{}", server);
         log::info!("lws server is {}", addr);
         let rpcs = RpcPool::new(10, addr).await?;
@@ -1523,7 +1527,7 @@ impl LwsVfsIns {
             config,
             rpcs,
             vir_root,
-            cache:FileAttrCacheManager::new(),
+            cache: FileAttrCacheManager::new(cache_life),
         })
     }
 
@@ -1543,7 +1547,10 @@ impl LwsVfsIns {
             Ok(resp) => resp.into_inner(),
             Err(e) => {
                 log::error!("get resp err: {:?}", e);
-                return Err(Box::new(std::io::Error::new(std::io::ErrorKind::Other, "get config err")));
+                return Err(Box::new(std::io::Error::new(
+                    std::io::ErrorKind::Other,
+                    "get config err",
+                )));
             }
         };
         let config = Config::new(&resp.config).expect("parse config err");